Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36210 )
Change subject: security/vboot: Add new Kconfig option VBOOT_EARLY_EC_SYNC
......................................................................
Patch Set 8:
(1 comment)
Patch Set 8:
Why isn't this patch squashed w/ the introduction of the feature and compilation unit itself?
I guess it could be. The code as is should be able to run in ramstage or romstage, so this is the one that compiles it into romstage.
https://review.coreboot.org/c/coreboot/+/36210/8/src/security/vboot/Kconfig
File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/36210/8/src/security/vboot/Kconfig@...
PS8, Line 228: "Perform EC software sync in romstage"
Does this need to be a user-visible option?
Hmm, probably not. Something I'd expect we'd dump into config.${BOARD}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36210
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56edcd385467edb5e91168dc59427d86fa9581d7
Gerrit-Change-Number: 36210
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 29 Oct 2019 21:50:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment