Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47829 )
Change subject: util/cbfstool: Treat region offsets differently than absolute addresses
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47829/9/util/cbfstool/cbfstool.c
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/47829/9/util/cbfstool/cbfstool.c@14...
PS9, Line 149: return 0;
this doesn't result in an error being propagated to the caller (it just assigns the return value) but changing that would require updating the semantics.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib74a7e6ed9e88fbc5489640d73bedac14872953f
Gerrit-Change-Number: 47829
Gerrit-PatchSet: 9
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Dec 2020 19:52:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment