Attention is currently required from: CoolStar.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74813 )
Change subject: drivers/sof: Add new driver to generate ACPI _DSD table ......................................................................
Patch Set 1:
(6 comments)
File src/drivers/sof/sof.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175142): https://review.coreboot.org/c/coreboot/+/74813/comment/0856927c_16f14030 PS1, Line 11: static const char *get_spkr_tplg_str(unsigned int index) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175142): https://review.coreboot.org/c/coreboot/+/74813/comment/61856068_160923b0 PS1, Line 12: switch (index) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175142): https://review.coreboot.org/c/coreboot/+/74813/comment/00ee38c1_d9bd450d PS1, Line 24: static const char *get_jack_tplg_str(unsigned int index) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175142): https://review.coreboot.org/c/coreboot/+/74813/comment/b7158cfb_8861623b PS1, Line 25: switch (index) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175142): https://review.coreboot.org/c/coreboot/+/74813/comment/1a3d0a0c_927a3745 PS1, Line 35: static const char *get_mic_tplg_str(unsigned int index) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175142): https://review.coreboot.org/c/coreboot/+/74813/comment/6f56fb8b_701f6cc6 PS1, Line 36: switch (index) that open brace { should be on the previous line