Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44820 )
Change subject: util/ifdtool: Fix eSPI frequency as per Gen 11 SPI flash guide
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44820/3/util/ifdtool/ifdtool.c
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/44820/3/util/ifdtool/ifdtool.c@638
PS3, Line 638: if (is_platform_with_100x_series_pch()) {
suggestion:
if (is_platform_with_100x_series_pch() && chipset != CHIPSET_100_200_SERIES_SUNRISE_POINT) {
...
} else {
}
that way it's a little more clear that sunrise point is the same as non-100x series here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44820
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20840e6f931d7c1fabea0b6892e3bd19ead81168
Gerrit-Change-Number: 44820
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 27 Aug 2020 17:24:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment