Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45588 )
Change subject: spd: move weak mainboard_get_dram_part_num implementation to lib/spd_bin.c
......................................................................
Patch Set 18:
(1 comment)
This is now ready for review.
https://review.coreboot.org/c/coreboot/+/45588/8/src/mainboard/google/dedede...
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/45588/8/src/mainboard/google/dedede...
PS8, Line 40: CHROMEOS_DRAM_PART_NUMBER_IN_CBI
!ROMSTAGE_SPD_SMBUS is required only in mainboard hatch because it supports Hatch reference (using m […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45588
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie173b81b9c9a98f3744cc9da4b034d2251f5589b
Gerrit-Change-Number: 45588
Gerrit-PatchSet: 18
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Wed, 23 Sep 2020 18:24:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment