[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Support to initialize Memory

[Varun Joshi (Code Review)]

Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39847 )

Change subject: soc/intel/tigerlake: Support to initialize Memory
......................................................................

Patch Set 10:

(4 comments)

https://review.coreboot.org/c/coreboot/+/39847/1/src/soc/intel/tigerlake/mem... 
File src/soc/intel/tigerlake/meminit_tgl.c:

https://review.coreboot.org/c/coreboot/+/39847/1/src/soc/intel/tigerlake/mem... 
PS1, Line 177: TigerLake
> Tiger Lake

Done

https://review.coreboot.org/c/coreboot/+/39847/1/src/soc/intel/tigerlake/mem... 
PS1, Line 179: 			   const struct mb_lpddr4x_cfg *board_cfg)
> Fits in one line.

Done

https://review.coreboot.org/c/coreboot/+/39847/1/src/soc/intel/tigerlake/mem... 
PS1, Line 188: int
> unsigned int i

Done

https://review.coreboot.org/c/coreboot/+/39847/1/src/soc/intel/tigerlake/mem... 
PS1, Line 203: }
> I think the code here should be organized such that we don't duplicate a lot of stuff: […]

Done