Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36775 )
Change subject: mb/*/*{i440BX}: Enable console in bootblock
......................................................................
Patch Set 7:
This concept has also been tested on asus/p2b-ls. However, I see nothing interesting during bootblock stage. Since it made the bootblock significantly larger, I would want this to be a compile time option, that would also see serial enabled during bootblock (and no need to do it again during romstage.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36775
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87e5eb93c15a72f790739eff8395e7eecbf1eb04
Gerrit-Change-Number: 36775
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Branden Waldner
scruffy99@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 02 Feb 2020 04:36:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment