Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38281 )
Change subject: mb/google/dedede: Enable ChromeOS ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38281/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/38281/4/src/mainboard/google/dedede... PS4, Line 15: bool : default y
tabs instead of spaces.
Done
https://review.coreboot.org/c/coreboot/+/38281/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/chromeos.c:
https://review.coreboot.org/c/coreboot/+/38281/4/src/mainboard/google/dedede... PS4, Line 29: return 1;
Actually it can be removed here. I removed it in the EC patch where EC Switches are enabled. […]
Done
https://review.coreboot.org/c/coreboot/+/38281/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/38281/4/src/mainboard/google/dedede... PS4, Line 51: *
__weak
Done