Attention is currently required from: Nico Huber, Paul Menzel, Felix Held.
Clay Daniels has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D
......................................................................
Patch Set 10:
(3 comments)
Patchset:
PS10:
Your superiotool dump [1] looks very reasonable. Please update […]
Thanks. I just copied your NANA entries from NTC6791D.
PS10:
Nico, thanks for all the help. I think I have this set up right now, but the mechanics of Gerrit are new to me.
File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/49112/comment/b7b3ff9d_57342912
PS10, Line 570: NCT6797D
As we can never be 100% without a datasheet, how about naming this like […]
Done: you are right, without a datasheet, we are doing educated guessing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49112
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f
Gerrit-Change-Number: 49112
Gerrit-PatchSet: 10
Gerrit-Owner: Clay Daniels
clay.daniels.jr@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 26 Jan 2021 18:34:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
