Attention is currently required from: Arthur Heymans, Marc Jones, Wonkyu Kim, Subrata Banik, Jonathan Zhang, Daocheng Bu, Rizwan Qureshi, Jingle Hsu, Sridhar Siricilla, Shuming Chu (Shuming), Shelly Chang.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66579 )
Change subject: soc/intel/cmn: Clear interrupt status after HECI-1 has been received
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/66579/comment/8fe0be4c_749ab08a
PS4, Line 15: get_me_fw_version
Thanks Johnny for clarification. […]
My test result:
The interrupt status is not set before and after line 542 clear_int();
The interrupt status is set right before line 572 return CSE_TX_RX_SUCCESS;
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/66579/comment/95163074_cb99689d
PS4, Line 542: clear_int();
Is this too early in your platform? Can you check interrupt status before this code clears?
Yes it's too early.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66579
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cf21112870e53a11134d43e461b735ead239717
Gerrit-Change-Number: 66579
Gerrit-PatchSet: 4
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Daocheng Bu
daocheng.bu@intel.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Reviewer: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Daocheng Bu
daocheng.bu@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Comment-Date: Thu, 03 Nov 2022 06:28:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment