Attention is currently required from: Martin L Roth, Michał Kopeć, Stefan Reinauer, Michael Niewöhner.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62497 )
Change subject: payloads/tianocore: Allow custom build parameters for custom builds
......................................................................
Patch Set 10: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62497/comment/ac85144a_d23552d1
PS1, Line 7: for custom builds
I'd just drop that
+1
File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/62497/comment/c4505263_7cf0879e
PS10, Line 192: string "TianoCore custom build parameters"
I would put the word 'additional' somewhere in this line. People may skip reading the full description and repeat common parameters here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62497
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I025459ae94592103b4be0c68b422100b7c649d34
Gerrit-Change-Number: 62497
Gerrit-PatchSet: 10
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin L Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth
martinroth@google.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Mon, 02 May 2022 13:58:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment