Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Ravi Kumar Bokka, Julius Werner. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45205 )
Change subject: sc7280: Provide initial SoC support ......................................................................
Patch Set 41:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/45205/comment/2820a8fa_fd10d234 PS41, Line 8: The main question, that needs to be answered from my point of view is, what the difference to SC7180 is, and why the difference is big enough, that it’s a new directory.
https://review.coreboot.org/c/coreboot/+/45205/comment/7c0cd685_01f60547 PS41, Line 10: qualcomm sc7280 developement board herobrine?
https://review.coreboot.org/c/coreboot/+/45205/comment/8ba4351f_c30c0171 PS41, Line 10: TEST=Validated on qualcomm sc7280 developement board What worked? Judging from the code not much, so maybe write, it’s just build tested?
File Documentation/soc/qualcomm/sc7280/index.md:
https://review.coreboot.org/c/coreboot/+/45205/comment/9ce1bf12_01612fe5 PS41, Line 18: Please remove the blank lines at the end of the file.
File src/soc/qualcomm/sc7280/Kconfig:
https://review.coreboot.org/c/coreboot/+/45205/comment/e9869468_49dfb812 PS41, Line 1: Please remove this blank line.
File src/soc/qualcomm/sc7280/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45205/comment/c9c97802_8b83a6e5 PS41, Line 1: Please remove the blank line.
File src/soc/qualcomm/sc7280/bootblock.c:
https://review.coreboot.org/c/coreboot/+/45205/comment/c0717515_e8f132ff PS41, Line 8: sc7280_mmu_init(); For the SC7180 this is done in decompressor.
File src/soc/qualcomm/sc7280/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/45205/comment/b9882b8d_972472c1 PS41, Line 30: 84K Why not 83K as in SC7180?