Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47800 )
Change subject: WIP: soc/mediatek/mt8192: add i2c driver support
......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47800/3//COMMIT_MSG
Commit Message:
PS3:
Just keep this
Then please abandon CB:46573, and add this patch to ToT.
https://review.coreboot.org/c/coreboot/+/47800/3//COMMIT_MSG@7
PS3, Line 7: WIP:
Ack
Not done? Please resolve a comment only after it's been addressed.
https://review.coreboot.org/c/coreboot/+/47800/3//COMMIT_MSG@9
PS3, Line 9: e
Ack
Not done?
https://review.coreboot.org/c/coreboot/+/47800/3//COMMIT_MSG@12
PS3, Line 12:
Ack
Not done?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13835e00eb674a93aa5496a9870d1e601e263368
Gerrit-Change-Number: 47800
Gerrit-PatchSet: 3
Gerrit-Owner: wang qii
Qii.Wang@mediatek.com
Gerrit-Reviewer: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Jg Daolongzhu
jg_daolongzhu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 27 Nov 2020 02:12:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: wang qii
Qii.Wang@mediatek.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment