[coreboot-gerrit] Change in ...coreboot[master]: src: Remove unused variables

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 )

Change subject: src: Remove unused variables
......................................................................

Patch Set 34:

(3 comments)

https://review.coreboot.org/#/c/29917/31/src/cpu/amd/quadcore/quadcore.c 
File src/cpu/amd/quadcore/quadcore.c:

https://review.coreboot.org/#/c/29917/31/src/cpu/amd/quadcore/quadcore.c@101 
PS31, Line 101: get_boot_apic_id(nodeid
> Adding the printk needs to be split to separate change.

I agree, this is not removing unused variables, but rather making them be used, so it's out of the scope of this patch.

https://review.coreboot.org/#/c/29917/34/src/soc/intel/fsp_baytrail/romstage... 
File src/soc/intel/fsp_baytrail/romstage/romstage.c:

https://review.coreboot.org/#/c/29917/34/src/soc/intel/fsp_baytrail/romstage... 
PS34, Line 247: 	cbmem_was_initted = !cbmem_recovery(prev_sleep_state == ACPI_S3);
              : 	if (!cbmem_was_initted)
              : 		printk(BIOS_ERR, "cbmem init failed\n");
The call to cbmem_recovery() can be put inside the if condition, eliminating the cbmem_was_initted variable completely. See the comment below

https://review.coreboot.org/#/c/29917/34/src/soc/intel/fsp_broadwell_de/roms... 
File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:

https://review.coreboot.org/#/c/29917/34/src/soc/intel/fsp_broadwell_de/roms... 
PS34, Line 114: 
              : 	if (cbmem_recovery(0))
              : 		printk(BIOS_ERR, "cbmem init failed\n");
This is nice.