HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )
Change subject: herobrine : Provide initial mainboard support ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45206/6/src/mainboard/google/herobr... File src/mainboard/google/herobrine/board.h:
https://review.coreboot.org/c/coreboot/+/45206/6/src/mainboard/google/herobr... PS6, Line 8: #include <soc/gpio.h> maybe you can remove direct 'include <soc/gpio.h>'
https://review.coreboot.org/c/coreboot/+/45206/6/src/mainboard/google/herobr... File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45206/6/src/mainboard/google/herobr... PS6, Line 5: #include <arch/mmio.h> : #include <gpio.h> : #include <timestamp.h> maybe not used