Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38860 )
Change subject: mb/google/hatch: Create palkia variant
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38860/6/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/palkia/gpio.c:
https://review.coreboot.org/c/coreboot/+/38860/6/src/mainboard/google/hatch/...
PS6, Line 4: Google LLC
Add pegatron as well?
Done.
https://review.coreboot.org/c/coreboot/+/38860/6/src/mainboard/google/hatch/...
PS6, Line 4: 2019
coreboot is switching to SPDX-style headers. you can grep the source to see what it looks like. […]
I can only found SPDX-style header in gpio.h of certain project . Could i use the same description on gpio.c ?
"SPDX-License-Identifier: GPL-2.0-or-later"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38860
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a303d9fc2be9ea358ad66cd648738187c974193
Gerrit-Change-Number: 38860
Gerrit-PatchSet: 13
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 20 Feb 2020 10:49:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment