Attention is currently required from: Raul Rangel, Aaron Durbin, Furquan Shaikh, Marshall Dawson, Julius Werner, Eric Peers.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56047 )
Change subject: commonlib/bsd/future: Introduce future API
......................................................................
Patch Set 1:
(3 comments)
File src/commonlib/bsd/include/commonlib/bsd/future.h:
https://review.coreboot.org/c/coreboot/+/56047/comment/b3b63fef_6e408ecc
PS1, Line 1: /* SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0-or-later */
curious - why did this go in bsd?
Why not?
https://review.coreboot.org/c/coreboot/+/56047/comment/611e60ae_4834100e
PS1, Line 59: !!
nit: redundant, return value already does this conversion
https://review.coreboot.org/c/coreboot/+/56047/comment/9b41ccdc_6a09bee7
PS1, Line 83:
nit: one space too many
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56047
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I125a946233f122c2848704296efbcb3ca3c96079
Gerrit-Change-Number: 56047
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Aaron Durbin
adurbin@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Comment-Date: Wed, 07 Jul 2021 14:43:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Peers
epeers@google.com
Gerrit-MessageType: comment