Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33652 )
Change subject: arch/x86/acpi: Add os.asl
......................................................................
Patch Set 1:
Only useful if supporting Windows. I doubt an open source project would use $$$ Microsoft.
Many do, but I assume mostly only support for a single version
is necessary. Linux has its bugs too, so one cannot say that
this is only about Windows. But generally, I prefer to add work-
arounds for specific OS's only case-by-case when one really has
the means to test it. And then the workaround should be commen-
ted as what it is. That's much better than a choice of per OS
paths by default where it's not recognizable which path has to
stay as is (workaround) and which can be adapted/unified (not
saying that this change would have led to the latter, it's just
what happened in some firmware in the past).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33652
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87200cafdafcf078db16c95463a86c3e9105cea6
Gerrit-Change-Number: 33652
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sun, 07 Jul 2019 13:39:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment