Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30989 )
Change subject: intelblocks/systemagent: Add ACPI table generation hook
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/30989/2/src/soc/intel/common/block/systemage...
File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/#/c/30989/2/src/soc/intel/common/block/systemage...
PS2, Line 23: #include <intelblocks/acpi.h>
No specific reason, will sort the include.
Done
https://review.coreboot.org/#/c/30989/4/src/soc/intel/common/block/systemage...
File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/#/c/30989/4/src/soc/intel/common/block/systemage...
PS4, Line 24:
You dropped this include, was this intentional?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30989
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1333ae2b79f1a855e6f3bb39bf534da170ddc9e1
Gerrit-Change-Number: 30989
Gerrit-PatchSet: 4
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alex Thiessen
alex.thiessen.de+coreboot@gmail.com
Gerrit-Comment-Date: Wed, 23 Jan 2019 12:56:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: Alex Thiessen
alex.thiessen.de+coreboot@gmail.com
Gerrit-MessageType: comment