Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32054 )
Change subject: nb/intel/pineview: Correct unsigned integer check in msbpos
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32054/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32054/2//COMMIT_MSG@15
PS2, Line 15: Also fix checkpatch trailing statement lints.
Next time a separate commit would be appreciated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32054
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5be50846cc545dcd48593e5ed3fd6068a6104cb
Gerrit-Change-Number: 32054
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Damien Zammit
damien@zamaudio.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Mar 2019 09:47:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment