[coreboot-gerrit] Change in coreboot[master]: [RFC] Documentation/fsp: Discuss FSP-S issues

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36328 )

Change subject: [RFC] Documentation/fsp: Discuss FSP-S issues
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36328/4/Documentation/fsp/fsp-s_dis... 
File Documentation/fsp/fsp-s_discussion.md:

https://review.coreboot.org/c/coreboot/+/36328/4/Documentation/fsp/fsp-s_dis... 
PS4, Line 99: This shows that no matter the many options that are implemented in
            : FSP-S
> Ah, understood. […]

I would rephrase this a bit:

This shows that, no matter how many options are implemented in FSP-S, there will always be...

https://review.coreboot.org/c/coreboot/+/36328/4/Documentation/fsp/fsp-s_dis... 
PS4, Line 194: or raise legal concerns
> > Thanks for pointing this out. As mentioned somewhere above, there is a lack of documentation. It's a shame that information like this needs to be "leaked".
>
> Apologize this was not clear. I thought it was mentioned in the integration guide but it appears to not be. Can you file a issue on IntelFsp to remind me to go fix that?

Done: https://github.com/IntelFsp/FSP/issues/47