Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38281 )
Change subject: mb/google/dedede: Enable ChromeOS
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38281/4/src/mainboard/google/dedede...
File src/mainboard/google/dedede/chromeos.c:
https://review.coreboot.org/c/coreboot/+/38281/4/src/mainboard/google/dedede...
PS4, Line 29: return 1;
TODO to use ec/google/chromeec/switches. […]
Actually it can be removed here. I removed it in the EC patch where EC Switches are enabled. I will remove it here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38281
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb94849a903e4d4364d817de8988a430cd717e4c
Gerrit-Change-Number: 38281
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 09 Jan 2020 23:26:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin TerAvest
teravest@chromium.org
Gerrit-MessageType: comment