Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37802 )
Change subject: documentation: Add documentation on setting up mainboard GPIOs
......................................................................
Patch Set 2:
Shouldn't we call it "pin" or "pad" configuration? I know, in
coreboot we still refer to it as GPIO config. But it might
confuse new people that expect this to be about dedicated GPIO
pins.
Also, GPIO is sometimes confused with pins available to the
platform user, while in coreboot it's mostly about pins controlled
by the firmware.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37802
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I279eec4ed2bb0248a2bdb363fb73b40b8272267f
Gerrit-Change-Number: 37802
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Justin TerAvest
teravest@chromium.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 29 Dec 2019 21:11:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment