Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43796 )
Change subject: soc/mediatek/mt8183: Transfer ddr geometry type to dram blob
......................................................................
Patch Set 13:
(1 comment)
thanks - very close, please fix the last one.
https://review.coreboot.org/c/coreboot/+/43796/13/src/soc/mediatek/mt8183/me...
File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/43796/13/src/soc/mediatek/mt8183/me...
PS13, Line 101: u32 ddr_geometry, u16 config)
please indent this with previous line, e.g.
static int dram_run_full_calibration(struct dramc_param *dparam,
u32 ddr_geometry, u16 config)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a677195f5036321939c60c8f9f1bace7c4a2e3f
Gerrit-Change-Number: 43796
Gerrit-PatchSet: 13
Gerrit-Owner: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 10 Aug 2020 08:39:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment