[coreboot-gerrit] Change in coreboot[master]: arch/x86: Pass GNVS as parameter to SMM module

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48698 )

Change subject: arch/x86: Pass GNVS as parameter to SMM module
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48698/4/src/cpu/x86/smm/smm_module_... 
File src/cpu/x86/smm/smm_module_handler.c:

https://review.coreboot.org/c/coreboot/+/48698/4/src/cpu/x86/smm/smm_module_... 
PS4, Line 139: 		gnvs = (void *)(uintptr_t)smm_runtime->gnvs_ptr;
> Hmmm, platforms had a call to `smm_points_to_smram` here, but I'm not sure if implementing this chec […]

The test was there to validate a user-supplied pointer in SMI handler. Given that coreboot was already supposed to raise APM_CNT_GNVS_UPDATE and set smm_initialized=1, can you determine if the test was ever actually reached (with user-supplied pointer).

This is no longer a user-supplied pointer and the SMI handler in question is removed.