Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46962 )
Change subject: mb/google/hatch/jinlon: Describe the privacy_gpio
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46962/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/jinlon/gpio.c:
https://review.coreboot.org/c/coreboot/+/46962/2/src/mainboard/google/hatch/...
PS2, Line 22: PAD_CFG_GPI
Then shouldn't this be `PAD_CFG_GPI_INT(GPP_D4, NONE, PLTRST, EDGE_BOTH)` ? or does the kernel recon […]
Good catch!! For some reason I lost that change when moving from my chromeos test to review.
Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46962
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa628dda03f3f65976850aeabaf516f528a921b7
Gerrit-Change-Number: 46962
Gerrit-PatchSet: 3
Gerrit-Owner: Ricardo Ribalda
ribalda@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 04 Nov 2020 23:48:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment