[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configu...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33129 )

Change subject: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configuration
......................................................................

Patch Set 12:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33129/12/src/soc/intel/common/pch/t... 
File src/soc/intel/common/pch/thermal/thermal.c:

PS12:
> Even if an IP block is not used by a particular family, it should be part of common/block and the So […]

thats the correct expectation Furquan but we were also assessing how do we make more common code based on PCH common alignment, if you see pch/kconfig is now selecting all those common IP from single place rather duplicating those into core platform (SKL, CNL, ICL etc) kconfig like atom socs. It minimizes the maintain headache and also avoid unnecessary common approach which is not common between core and atom. (that was the key idea for pch directory)