Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39795 )
Change subject: soc/intel/cnl: Fix `PcieClkSrcUsage` setting
......................................................................
Patch Set 1:
Patch Set 1:
Yeah, sorry, the commit message was stale. That's why the original, vanished?
change was [WIP]. The actual problem with the for-loop is that it replaces
Clock Source 0 with garbage, i.e. you can't configure 0 for any board because
somebody took the weirdest shortcut, using the fact that unset devicetree
options default to 0. But 0 is a valid value :-/
s/Clock Source 0/Clock Source for the first root port/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39795
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb2192e68e29ae53fcdd0775ac7fd6cea2930a0e
Gerrit-Change-Number: 39795
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 24 Mar 2020 10:38:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment