Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/em100/+/35066 )
Change subject: firmware.c: Check pointer returned by malloc
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/em100/+/35066/1/firmware.c
File firmware.c:
https://review.coreboot.org/c/em100/+/35066/1/firmware.c@195
PS1, Line 195: printf("ERROR: out of memory.\n");
Maybe fclose(f) before returning.
--
To view, visit
https://review.coreboot.org/c/em100/+/35066
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: Iecf92a9acc54a4ab0a94867e5db265e1db943d53
Gerrit-Change-Number: 35066
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 30 Aug 2019 03:42:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment