Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41159 )
Change subject: mainboard: Add HP EliteBook 2560p ......................................................................
Patch Set 5:
(15 comments)
https://review.coreboot.org/c/coreboot/+/41159/4/Documentation/mainboard/hp/... File Documentation/mainboard/hp/2560p.md:
https://review.coreboot.org/c/coreboot/+/41159/4/Documentation/mainboard/hp/... PS4, Line 8: secondhand
second-hand
I think both forms are right. https://en.wiktionary.org/wiki/secondhand
https://review.coreboot.org/c/coreboot/+/41159/4/Documentation/mainboard/hp/... PS4, Line 37:
two empty lines
Done
https://review.coreboot.org/c/coreboot/+/41159/4/Documentation/mainboard/hp/... PS4, Line 64: integrated
Integrated
Done
https://review.coreboot.org/c/coreboot/+/41159/4/Documentation/mainboard/hp/... PS4, Line 66: audio
Audio
Done
https://review.coreboot.org/c/coreboot/+/41159/4/Documentation/mainboard/hp/... PS4, Line 70: bluetooth
BlueTooth
Done. The first letter T in "bluetooth" is not upper cased according to https://www.bluetooth.com/.
https://review.coreboot.org/c/coreboot/+/41159/4/Documentation/mainboard/hp/... PS4, Line 76: keyboard
Keyboard
Done
https://review.coreboot.org/c/coreboot/+/41159/4/Documentation/mainboard/hp/... PS4, Line 78: internal
Internal
Done
https://review.coreboot.org/c/coreboot/+/41159/4/Documentation/mainboard/hp/... PS4, Line 79: using
Using
Done
https://review.coreboot.org/c/coreboot/+/41159/4/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/2560p/early_init.c:
https://review.coreboot.org/c/coreboot/+/41159/4/src/mainboard/hp/snb_ivb_la... PS4, Line 2: /* This file is part of the coreboot project. */
Remove this
Done
https://review.coreboot.org/c/coreboot/+/41159/4/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/2560p/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/41159/4/src/mainboard/hp/snb_ivb_la... PS4, Line 2: -- This file is part of the coreboot project.
Remove this
Done
https://review.coreboot.org/c/coreboot/+/41159/4/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/2560p/gpio.c:
https://review.coreboot.org/c/coreboot/+/41159/4/src/mainboard/hp/snb_ivb_la... PS4, Line 2: /* This file is part of the coreboot project. */
Remove this
Done
https://review.coreboot.org/c/coreboot/+/41159/4/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/2560p/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/41159/4/src/mainboard/hp/snb_ivb_la... PS4, Line 2: /* This file is part of the coreboot project. */
Remove this
Done
https://review.coreboot.org/c/coreboot/+/41159/4/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/2560p/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41159/4/src/mainboard/hp/snb_ivb_la... PS4, Line 2: # This file is part of the coreboot project.
Remove this
Done
https://review.coreboot.org/c/coreboot/+/41159/4/src/mainboard/hp/snb_ivb_la... PS4, Line 22: # HDD(0), ODD(1), eSATA(4) : register "sata_port_map" = "0x33"
This is not consistent. […]
Done
https://review.coreboot.org/c/coreboot/+/41159/4/src/mainboard/hp/snb_ivb_la... PS4, Line 25: device pci 1c.0 on end # PCIe Port #1
Does this need to be enabled?
Done