[coreboot-gerrit] Change in coreboot[master]: amd/common/block/spi: Add EFS SPI configurations to Kconfig

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42567 )

Change subject: amd/common/block/spi: Add EFS SPI configurations to Kconfig
......................................................................

Patch Set 17:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42567/17/src/soc/amd/common/block/s... 
File src/soc/amd/common/block/spi/Kconfig:

https://review.coreboot.org/c/coreboot/+/42567/17/src/soc/amd/common/block/s... 
PS17, Line 15: 	range 0 7
> nit: default 0 if EM100

Why are you looking to change the EM100 setting here? EM100 on zork support 2 and 4.

https://review.coreboot.org/c/coreboot/+/42567/17/src/soc/amd/common/block/s... 
PS17, Line 33: 	range 0 5
> default 3 if EM100

This is only a zork limitation isn't it? I'm sure that other boards could support a faster speed since they wouldn't use the yoshi cable. I think we should leave the EM100 settings in the zork Kconfig.

Thoughts?