Hello Raul Rangel,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/39885
to review the following change.
Change subject: soc/amd/picasso: Add and use CPUID defines for Picasso and Raven2 ......................................................................
soc/amd/picasso: Add and use CPUID defines for Picasso and Raven2
Change-Id: I35a1c404ff2f381d3d6bf4f2e4bbbf5429db38c3 Signed-off-by: Martin Roth martinroth@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1961485 Reviewed-on: https://chromium-review.googlesource.com/2060905 Reviewed-by: Raul E Rangel rrangel@chromium.org --- M src/soc/amd/picasso/cpu.c M src/soc/amd/picasso/include/soc/cpu.h 2 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/39885/1
diff --git a/src/soc/amd/picasso/cpu.c b/src/soc/amd/picasso/cpu.c index c7e847d..6044688 100644 --- a/src/soc/amd/picasso/cpu.c +++ b/src/soc/amd/picasso/cpu.c @@ -128,8 +128,8 @@
static struct cpu_device_id cpu_table[] = { { X86_VENDOR_AMD, 0x810f80 }, - { X86_VENDOR_AMD, 0x810f81 }, - { X86_VENDOR_AMD, 0x820f01 }, + { X86_VENDOR_AMD, PICASSO_CPUID }, + { X86_VENDOR_AMD, RAVEN2_CPUID }, { 0, 0 }, };
diff --git a/src/soc/amd/picasso/include/soc/cpu.h b/src/soc/amd/picasso/include/soc/cpu.h index 2bcffdc..c53829d 100644 --- a/src/soc/amd/picasso/include/soc/cpu.h +++ b/src/soc/amd/picasso/include/soc/cpu.h @@ -23,4 +23,7 @@ int get_cpu_count(void); void check_mca(void);
+#define PICASSO_CPUID 0x00810f81 +#define RAVEN2_CPUID 0x00820f01 + #endif /* __PICASSO_CPU_H__ */