build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39140 )
Change subject: mb/google/puff: enable retraining memory support ......................................................................
Patch Set 1:
(27 comments)
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/romstage_spd_smbus.c:
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 59: void mainboard_prepare_dimm_info(FSPM_UPD *upd, void* data, size_t *data_sz) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 66: spd1_ptr = (uint8_t*) upd->FspmConfig.MemorySpdPtr00; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 66: spd1_ptr = (uint8_t*) upd->FspmConfig.MemorySpdPtr00; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 66: spd1_ptr = (uint8_t*) upd->FspmConfig.MemorySpdPtr00; "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 67: spd2_ptr = (uint8_t*) upd->FspmConfig.MemorySpdPtr10; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 67: spd2_ptr = (uint8_t*) upd->FspmConfig.MemorySpdPtr10; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 67: spd2_ptr = (uint8_t*) upd->FspmConfig.MemorySpdPtr10; "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 69: if (spd1_ptr != NULL) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 69: if (spd1_ptr != NULL) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 71: memcpy(&dimm_data[0].serial_no, spd1_ptr + DDR4_SPD_SN_OFF, DDR4_SPD_SN_LEN); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 71: memcpy(&dimm_data[0].serial_no, spd1_ptr + DDR4_SPD_SN_OFF, DDR4_SPD_SN_LEN); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 72: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 72: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 74: if (spd2_ptr != NULL) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 74: if (spd2_ptr != NULL) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 75: memcpy(&dimm_data[1].part, spd2_ptr + DDR4_SPD_PART_OFF, DDR4_SPD_PART_LEN); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 75: memcpy(&dimm_data[1].part, spd2_ptr + DDR4_SPD_PART_OFF, DDR4_SPD_PART_LEN); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 76: memcpy(&dimm_data[1].serial_no, spd2_ptr + DDR4_SPD_SN_OFF, DDR4_SPD_SN_LEN); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 76: memcpy(&dimm_data[1].serial_no, spd2_ptr + DDR4_SPD_SN_OFF, DDR4_SPD_SN_LEN); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 77: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 77: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 87: spd1_ptr = (uint8_t*) upd->FspmConfig.MemorySpdPtr00; "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 88: spd2_ptr = (uint8_t*) upd->FspmConfig.MemorySpdPtr10; "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 94: if ((memcmp(&dimm_data[0].part, spd1_ptr + DDR4_SPD_PART_OFF, DDR4_SPD_PART_LEN) != 0) && line over 96 characters
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 95: (memcmp(&dimm_data[0].serial_no, spd1_ptr + DDR4_SPD_SN_OFF, DDR4_SPD_SN_LEN) != 0)) line over 96 characters
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 103: if ((memcmp(&dimm_data[1].part, spd2_ptr + DDR4_SPD_PART_OFF, DDR4_SPD_PART_LEN) != 0) && line over 96 characters
https://review.coreboot.org/c/coreboot/+/39140/1/src/mainboard/google/hatch/... PS1, Line 104: (memcmp(&dimm_data[1].serial_no, spd2_ptr + DDR4_SPD_SN_OFF, DDR4_SPD_SN_LEN) != 0)) line over 96 characters