Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33573 )
Change subject: soc/intel/denverton_ns/include/soc/gpio_defs: Fix value of B_PCH_GPIO_RX_SCI_ROUTE ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
You can edit the commit message in Gerrit, without losing the votes.
https://review.coreboot.org/#/c/33573/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33573/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/denverton_ns/include/soc/gpio_defs: Fix value of B_PCH_GPIO_RX_SCI_ROUTE `soc/intel/dnv` should be enough as prefix, it shouldn't be the full path.
Generally, the summary line should be limited around 55 to 65 chars, 72 chars maximum.
https://review.coreboot.org/#/c/33573/1//COMMIT_MSG@9 PS1, Line 9: The value for that macro should be 1<<19. This is confirmed by the intel doc Should be broken at 72 chars, too.