Attention is currently required from: Subrata Banik, Yuchen He.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73866 )
Change subject: intel/common/block/smm: remove return statements from void functions
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Looks good to me. All other places from soc/intel/common have either a no-op comment or not even that (just an empty body).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73866
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3fb8217cfcae65b5dc317458b59aa431f1ccdaef
Gerrit-Change-Number: 73866
Gerrit-PatchSet: 1
Gerrit-Owner: Yuchen He
yuchenhe126@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Yuchen He
yuchenhe126@gmail.com
Gerrit-Comment-Date: Wed, 22 Mar 2023 03:58:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment