[coreboot-gerrit] Change in ...coreboot[master]: sdm845: Add SPI QUP driver

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27483 )

Change subject: sdm845: Add SPI QUP driver
......................................................................

Patch Set 53:

(2 comments)

Thanks, I think this looks good now, just needs one last fix. After that you could rebase it to the front of the series so we can land it already?

https://review.coreboot.org/#/c/27483/53/src/soc/qualcomm/sdm845/spi_qup.c 
File src/soc/qualcomm/sdm845/spi_qup.c:

https://review.coreboot.org/#/c/27483/53/src/soc/qualcomm/sdm845/spi_qup.c@1... 
PS53, Line 105: 		m_cmd = SPI_RX_ONLY;
Since we're only using din/dout to communicate the direction to qup_handle_transfer() now, we need to put an explicit dout = NULL here (and din = NULL in the case below)...

https://review.coreboot.org/#/c/27483/53/src/soc/qualcomm/sdm845/spi_qup.c@1... 
PS53, Line 129: dout + size
...otherwise this will screw things up if bytes_in is larger than bytes_out, because it will be non-NULL.