Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40762 )
Change subject: src/cpu/x86/mtrr/earlymtrr: Validate MTRR arguments ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/40762/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40762/3//COMMIT_MSG@10 PS3, Line 10: Programming says the following about variable MTRRs: FWIW, these constraints are x86 architectural.
https://review.coreboot.org/c/coreboot/+/40762/3//COMMIT_MSG@17 PS3, Line 17: 16-Mbyte boundary. aka naturally aligned
https://review.coreboot.org/c/coreboot/+/40762/3//COMMIT_MSG@24 PS3, Line 24: enabled. fyi, src/arch/x86/postcar_loader.c has code for setting up MTRRs based on regions passed in.