Attention is currently required from: TangYiwei.
Hello TangYiwei,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/68757
to review the following change.
Change subject: drivers/ipmi/ipmi_ops.h: add __packed to sel_rec structs ......................................................................
drivers/ipmi/ipmi_ops.h: add __packed to sel_rec structs
Change-Id: Icfcef684caa253663503eadffc819ad2ab65550f Signed-off-by: Yiwei Tang tangyiwei.2022@bytedance.com Signed-off-by: Jonathan Zhang jonzhang@meta.com --- M src/drivers/ipmi/ipmi_ops.h 1 file changed, 14 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/68757/1
diff --git a/src/drivers/ipmi/ipmi_ops.h b/src/drivers/ipmi/ipmi_ops.h index 7a92a28..788ae85 100644 --- a/src/drivers/ipmi/ipmi_ops.h +++ b/src/drivers/ipmi/ipmi_ops.h @@ -57,17 +57,17 @@ uint8_t sensor_num; uint8_t event_dir_type; uint8_t event_data[3]; -}; +} __packed;
struct oem_ts_spec_sel_rec { uint32_t timestamp; uint8_t manf_id[3]; uint8_t oem_defined[6]; -}; +} __packed;
struct oem_nots_spec_sel_rec { uint8_t oem_defined[13]; -}; +} __packed;
/* SEL Event Record */ struct sel_event_record {