Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45519 )
Change subject: soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45519/1/src/soc/amd/picasso/chip.h
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/45519/1/src/soc/amd/picasso/chip.h@...
PS1, Line 100: uint32_t thermctl_limit_tablet_mode;
Should we move this to around line 114 so the 2 configs are closer to one another?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45519
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id193a74210c92d1e45ed4824ee9c0fc9ceaa5e3a
Gerrit-Change-Number: 45519
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 18 Sep 2020 14:46:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment