Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47411 )
Change subject: soc/intel/common: Adapt XHCI elog driver for reuse
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47411/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/xhci/elog.c:
https://review.coreboot.org/c/coreboot/+/47411/3/src/soc/intel/common/block/...
PS3, Line 125: ELOG_WAKE_SOURCE_PME_XHCI_USB_3
USB4 status is very different from the others.... I think it will have to be a separate change.
Thanks for checking on the USB4 status, Tim. I agree it will have to be a separate change.
Going back to the original implementation for TCSS XHCI: Are you planning on reusing ELOG_WAKE_SOURCE_PME_XHCI_USB_3/ELOG_WAKE_SOURCE_PME_XHCI_USB_2 for TCSS?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47411
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f28354e031e3eda587f4faf8ef7595dce8b33ea
Gerrit-Change-Number: 47411
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Nov 2020 18:39:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment