Tommie Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43442 )
Change subject: mb/google/volteer: Create a new variant for Lingcod
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43442/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43442/4//COMMIT_MSG@17
PS4, Line 17: tong.lin
Please use “Tommie Lin”? (Or whatever is “correct”. […]
Done
https://review.coreboot.org/c/coreboot/+/43442/2/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/lingcod/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/43442/2/src/mainboard/google/voltee...
PS2, Line 8: /* Copied from baseboard and may need to change for the new variant. */
Any changes needed?
I have tuned GPIO based on Lingcod schematics.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43442
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f79431d3948788ce27ae14b469ffc229ebf8b6a
Gerrit-Change-Number: 43442
Gerrit-PatchSet: 5
Gerrit-Owner: Tommie Lin
tong.lin@bitland.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 15 Jul 2020 08:00:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment