[coreboot-gerrit] New patch to review for coreboot: 698d3ef AGESA: Static analysis warnings due to missing break (trivial)

[Bruce Griffith]

Bruce Griffith ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3539

-gerrit

commit 698d3ef77f289fecdc2fe4f8b7cf194a4d82130e
Author: Bruce Griffith 
Date:   Tue Jun 25 14:14:14 2013 -0600

AGESA: Static analysis warnings due to missing break (trivial)

Static analysis often flags case statements that do not include
    a terminating "break;" statement. Eclipse's CODAN is an example
    of this.  This changelist modifies amdlib.c to terminate
    case statements with "break;".

Change-Id: I3d43acaf64e2e2d9717421cb547fec35e582cf8b
    Signed-off-by: Bruce Griffith 
---
 src/vendorcode/amd/agesa/f15/Lib/amdlib.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/vendorcode/amd/agesa/f15/Lib/amdlib.c b/src/vendorcode/amd/agesa/f15/Lib/amdlib.c
index ca268ee..e51a971 100644
--- a/src/vendorcode/amd/agesa/f15/Lib/amdlib.c
+++ b/src/vendorcode/amd/agesa/f15/Lib/amdlib.c
@@ -285,6 +285,7 @@ LibAmdReadCpuReg (
       break;
     default:
       *Value = -1;
+      break;
   }
 }
 VOID
@@ -313,7 +314,7 @@ LibAmdWriteCpuReg (
       __writedr (7, Value);
       break;
     default:
-      ;
+      break;
   }
 }
 VOID
@@ -503,6 +504,7 @@ LibAmdIoRead (
     break;
   default:
     ASSERT (FALSE);
+    break;
   }
 }

@@ -540,6 +542,7 @@ LibAmdIoWrite (
     break;
   default:
     ASSERT (FALSE);
+    break;
   }
 }

@@ -640,6 +643,7 @@ LibAmdMemRead (
     break;
   default:
     ASSERT (FALSE);
+    break;
   }
 }

@@ -678,6 +682,7 @@ LibAmdMemWrite (
     break;
   default:
     ASSERT (FALSE);
+    break;
   }
 }
 /*---------------------------------------------------------------------------------------*/
@@ -1293,6 +1298,7 @@ LibAmdGetDataFromPtr (
     break;
   default:
     IDS_ERROR_TRAP;
+    break;
   }
 }

@@ -1333,6 +1339,7 @@ LibAmdAccessWidth (
   default:
     Width = 0;
     IDS_ERROR_TRAP;
+    break;
   }
   return Width;
 }