Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39454 )
Change subject: soc/intel/cannonlake: Steal no memory for disabled IGD
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39454/4/src/soc/intel/cannonlake/ro...
File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/39454/4/src/soc/intel/cannonlake/ro...
PS4, Line 36: InternalGfx
Did you check all CFL/CML/CNL boards that they select InternalGfx=1? If they don't it would introduce a regression as they won't boot any more.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39454
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f9e0f9855224614471d8ed23bf2a9786386ddca
Gerrit-Change-Number: 39454
Gerrit-PatchSet: 4
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Nate DeSimone
nateman1352@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 14 Mar 2020 20:53:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment