Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35157 )
Change subject: mb/google/drallion: memory spd data debug
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35157/4/src/mainboard/google/dralli...
File src/mainboard/google/drallion/romstage.c:
https://review.coreboot.org/c/coreboot/+/35157/4/src/mainboard/google/dralli...
PS4, Line 54: print_spd_info
If you add call to print_spd_info() here: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/cannonlake/..., then you wouldn't need all the logic to read SPD file again here in mainboard. Also, is there really a need to guard this with debug? I think its okay to print SPD info in SoC since it can be helpful.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35157
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8e448f6f53db4ea0fd2ffdc58699064716c1d57
Gerrit-Change-Number: 35157
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 03 Sep 2019 05:04:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment