1 comment:
File src/mainboard/google/drallion/romstage.c:
Patch Set #4, Line 54: print_spd_info
If you add call to print_spd_info() here: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/cannonlake/cnl_memcfg_init.c?id=refs/heads/master#n68, then you wouldn't need all the logic to read SPD file again here in mainboard. Also, is there really a need to guard this with debug? I think its okay to print SPD info in SoC since it can be helpful.
To view, visit change 35157. To unsubscribe, or for help writing mail filters, visit settings.