[coreboot-gerrit] Change in coreboot[master]: libpayload/defconfig: enable vboot Lib Build

[Julius Werner (Code Review)]

Attention is currently required from: Bora Guvendik, Anil Kumar K, Jakub Czapiga, Selma Bensaid, Tim Wawrzynczak, Balaji Manigandan.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63240 )

Change subject: libpayload/defconfig: enable vboot Lib Build
......................................................................

Patch Set 5:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/63240/comment/9d79d5b7_4d048514 
PS3, Line 9: #3461454
> Done

Sorry, I don't quite understand the use case here and I disagree with the conclusion. What exactly are you trying to build how and why?

I generally agree with everything Jakub said: depthcharge isn't meant to work with the defconfig, we specifically introduced CONFIG_LP_CHROMEOS to have a simple shorthand to select all the depthcharge-specific requirements, and if you want to build depthcharge you should just build with a config that enables CONFIG_LP_CHROMEOS, rather than changing the defconfig for everyone

I don't know who wrote the payloads/external/depthcharge stuff or the CONFIG_LP_DEFCONFIG_OVERRIDE in there, but if you want to make it work, why not just have that Makefile manually inject CONFIG_LP_CHROMEOS=y into that config after it copied it into the build dir? (That shouldn't be called CONFIG_LP_... btw, that prefix is explicitly meant for Kconfigs *in* libpayload, and payloads/external/depthcharge/Kconfig is not that.)