[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/alderlake: Add IBECC

[Maximilian Brune (Code Review)]

Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Christian Walter, Tim Wawrzynczak, David Milosevic.

Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68756 )

Change subject: soc/intel/alderlake: Add IBECC
......................................................................

Patch Set 9:

(2 comments)

File src/soc/intel/alderlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/68756/comment/0661afca_549653ad 
PS7, Line 382: 		printk(BIOS_DEBUG, "Enable IBECC\n");
> I don't think this is meaningful

Done

https://review.coreboot.org/c/coreboot/+/68756/comment/1778eb74_e81fc91d 
PS7, Line 369: 
             : 	/* In-Band ECC configuration */
             : 	if (config->ibecc.enable) {
             : 		m_cfg->Ibecc = config->ibecc.enable;
             : 		m_cfg->IbeccOperationMode = config->ibecc.mode;
             : 		if (m_cfg->IbeccOperationMode == IBECC_MODE_PER_REGION) {
             : 			FSP_ARRAY_LOAD(m_cfg->IbeccProtectedRangeEnable,
             : 				       config->ibecc.range_enable);
             : 			FSP_ARRAY_LOAD(m_cfg->IbeccProtectedRangeBase,
             : 				       config->ibecc.range_base);
             : 			FSP_ARRAY_LOAD(m_cfg->IbeccProtectedRangeMask,
             : 				       config->ibecc.range_mask);
             : 		}
             : 		printk(BIOS_DEBUG, "Enable IBECC\n");
             : 	}
> please help to create a small helper routine and call into it from line #364

Done
Although I think it's weird to create an array of callbacks in the first place. I don't see a reason to not just directly call all of them (would even reduce code size and enhance readability). But I guess that's something for another commit.