[coreboot-gerrit] Change in coreboot[master]: soc/intel/adl: Remove IOM Mctp command from TCSS ASL

[Maulik V Vaghela (Code Review)]

Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62861 )

Change subject: soc/intel/adl: Remove IOM Mctp command from TCSS ASL
......................................................................

soc/intel/adl: Remove IOM Mctp command from TCSS ASL

TCSS ASL code was carried forward from TGL and it used to follow the same
sequence.

Recently as part of s0ix hang issue, it was found that sending IOM
MCTP command as part of TCSS D3 Cold enter-exit sequence created an
issue. Due to change in hardware sequence, ADL should not set/reset
IOM MCTP during D3 cold entry or exit.

This patch removes the bit setting from ASL file to prevent hang
in the system

BUG=b:220796339
BRANCH=firmware-brya-14505.B
TEST=Check if hang issue is resolved with the CL and no other regression
observed

Change-Id: I2f066bcc4a8f475a15ddd12ef5ed87d7298312bb
Signed-off-by: MAULIK V VAGHELA 
---
M src/soc/intel/alderlake/acpi/tcss.asl
1 file changed, 0 insertions(+), 16 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/62861/1

diff --git a/src/soc/intel/alderlake/acpi/tcss.asl b/src/soc/intel/alderlake/acpi/tcss.asl
index 81c2432..73823f8 100644
--- a/src/soc/intel/alderlake/acpi/tcss.asl
+++ b/src/soc/intel/alderlake/acpi/tcss.asl
@@ -354,12 +354,6 @@
    	Offset(0x10),
    	RBAR, 64        /* RegBar, offset 0x7110 in MCHBAR */
    }
-	Field (MBAR, DWordAcc, NoLock, Preserve)
-	{
-		Offset(0x304),  /* PRIMDN_MASK1_0_0_0_MCHBAR_IMPH, offset 0x7404 */
-		,     31,
-		TCD3, 1         /* [31:31] TCSS IN D3 bit */
-	}

/*
     * Operation region defined to access the pCode mailbox interface. Get the MCHBAR
@@ -698,11 +692,6 @@
    		Else
    		{
    			/*
-				 * Program IOP MCTP Drop (TCSS_IN_D3) after D3 cold exit and
-				 * acknowledgement by IOM.
-				 */
-				TCD3 = 0
-				/*
    			 * If the TCSS Deven is cleared by BIOS Mailbox request, then
    			 * restore to previously saved value of TCSS DEVNE.
    			 */
@@ -749,11 +738,6 @@
    		}
    	}

-		/*
-		 * Program IOM MCTP Drop (TCSS_IN_D3) in D3Cold entry before entering D3 cold.
-		 */
-		TCD3 = 1
-
    	/* Request IOM for D3 cold entry sequence. */
    	TD3C = 1
    }