Attention is currently required from: Angel Pons, Angel Pons, Arthur Heymans, Christian Walter, Frans Hendriks, Intel coreboot Reviewers, Jincheng Li, Jérémy Compostella, Patrick Rudolph, Shuo Liu.
Hello Angel Pons, Angel Pons, Arthur Heymans, Christian Walter, Frans Hendriks, Intel coreboot Reviewers, Jincheng Li, Jérémy Compostella, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86567?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons, Code-Review+1 by Frans Hendriks, Code-Review+1 by Jérémy Compostella, Verified+1 by build bot (Jenkins)
Change subject: util/cbfstool: Add missing \n and use __func__ in debug messages
......................................................................
util/cbfstool: Add missing \n and use __func__ in debug messages
For adding missing \n, find all potential missings by below script
and apply manual checks and fixes.
grep -nE "(DEBUG|ERROR)(".+[^\n]"" util/cbfstool/ -r
For using __func__ in debug message, below script is used with
manual checks and fixes.
grep -nE "DEBUG(.+:" util/cbfstool/ -r
Change-Id: I3e2c225dc16a65470f9f94db89d8ec3711e781c8
Signed-off-by: Shuo Liu shuo.liu@intel.com
---
M util/cbfstool/cbfs_image.c
M util/cbfstool/fit.c
2 files changed, 18 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/86567/5
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86567?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3e2c225dc16a65470f9f94db89d8ec3711e781c8
Gerrit-Change-Number: 86567
Gerrit-PatchSet: 5
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Angel Pons
angel.pons@9elements.com