Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45637 )
Change subject: mb/clevo/cml-u: Remove duplicate Kconfig type definitions ......................................................................
Patch Set 3:
(16 comments)
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... File src/mainboard/clevo/cml-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 23: config MAINBOARD_DIR not yet declared globally; let's add it to src/mainboard/Kconfig
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 26: config MAINBOARD_PART_NUMBER : default "L140CU" if BOARD_CLEVO_L140CU : not yet declared globally; let's add it to src/Kconfig, where the other MAINBOARD_* options are located
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 29: config MAINBOARD_VERSION declared in src/Kconfig
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 32: config DEVICETREE declared in src/Kconfig
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 35: config CBFS_SIZE declared in src/Kconfig
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 38: config CONSOLE_POST declared in src/console/Kconfig
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 41: config UART_FOR_CONSOLE declared in src/console/Kconfig
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 44: MAX_CPUS declared in src/Kconfig
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 47: config DIMM_MAX declared in src/lib/Kconfig
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 50: config DIMM_SPD_SIZE declared in src/lib/Kconfig
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 53: config VGA_BIOS_FILE declared in src/device/Kconfig
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 56: config VGA_BIOS_ID declared in src/device/Kconfig
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 59: config TPM_PIRQ declared in src/drivers/pc80/tpm/Kconfig
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 62: config POST_DEVICE declared in src/console/Kconfig
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 65: config VARIANT_DIR not yet declared globally; let's add it to src/mainboard/Kconfig
https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 69: config SEABIOS_PS2_TIMEOUT declared in payloads/external/SeaBIOS/Kconfig